Summary
Description: Phoronix Test Suite open-source benchmarking development
Last Change: Fri 5/17/13 22:52
Recent Commits
>
--git a/CHANGE-LOG b/CHANGE-LOG
index bc35f02..4210f8b 100644
--- a/CHANGE-LOG
+++ b/CHANGE-LOG
@@ -3,6 +3,7 @@ PHORONIX TEST SUITE CHANGE-LOG
Phoronix Test Suite (Git)
- pts-core: Better recognize some open-source vs. closed-source graphics card/driver combination comparisons
+- pts-core: Fix potential crash in list-test-usage command
- pts_Graph: Fix rounding issue on pts tables that are very wide
Phoronix Test Suite 4.0 Milestone 1
diff --git a/pts-core/commands/list_test_usage.php b/pts-core/commands/list_test_usage.php
index ac43662..149d24c 100644
--- a/pts-core/commands/list_test_usage.php
+++ b/pts-core/commands/list_test_usage.php
@@ -3,8 +3,8 @@
/*
Phoronix Test Suite
URLs: http://www.phoronix.com, http://www.phoronix-test-suite.com/
- Copyright (C) 2008 - 2011, Phoronix Media
- Copyright (C) 2008 - 2011, Michael Larabel
+ Copyright (C) 2008 - 2012, Phoronix Media
+ Copyright (C) 2008 - 2012, Michael Larabel
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
@@ -37,7 +37,7 @@ class list_test_usage implements pts_option_interface
{
$test_profile = new pts_test_profile($identifier);
- if($test_profile != false && $test_profile->test_installation->get_installed_version() != null)
+ if($test_profile && $test_profile->test_installation && $test_profile->test_installation->get_installed_version() != null)
{
$avg_time = $test_profile->test_installation->get_average_run_time();
$avg_time = !empty($avg_time) ? pts_strings::format_time($avg_time, 'SECONDS', false) : 'N/A';
diff --git a/pts-core/objects/pts_Graph/pts_Graph.php b/pts-core/objects/pts_Graph/pts_Graph.php
index e4bb825..f26fb86 100644
--- a/pts-core/objects/pts_Graph/pts_Graph.php
+++ b/pts-core/objects/pts_Graph/pts_Graph.php
@@ -846,7 +846,7 @@ abstract class pts_Graph
}
$note_height += self::$c['size']['key'];
}
- $note_height += (count(array_unique($sections)) * (self::$c['size']['key'] + 6));
+ $note_height += ((count(array_unique($sections)) + 1) * (self::$c['size']['key'] + 6));
return $note_height;
Copyright © 2013 by Phoronix Media